6707e56f9c
* chore: update coverage badge [skip ci] * chore: update coverage badge [skip ci] * chore: update coverage badge [skip ci] * chore: update coverage badge [skip ci] * chore: update coverage badge [skip ci] * 1.0.19 changelog * stick opt * fix(cli): utf-8 safe sticky suffix guard + changelog (#272) SuffixLooksLikeValue used to read suffix[0] (a single byte) for both the uuid format branch and the fallback "is the first rune a letter?" check. For multi-byte UTF-8 leading runes — common in dws because value text is often Chinese — this picked up only the first byte (0xE0..0xF4 lead), which is not a letter and not a hex digit, so the function silently returned true and let glued tokens like --name<CJK> get split into --name <CJK>... This switches both branches to utf8.DecodeRuneInString and adds a utf8.RuneError guard so invalid UTF-8 input is rejected too. Also locks down the new behaviour in CHANGELOG ## [Unreleased]: - Changed: schema-aware sticky flag splitting - Added: available_flags field on unknown-flag errors Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
76 lines
2.4 KiB
Go
76 lines
2.4 KiB
Go
// Copyright 2026 Alibaba Group
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package app
|
|
|
|
import (
|
|
stderrors "errors"
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
|
|
apperrors "github.com/DingTalk-Real-AI/dingtalk-workspace-cli/internal/errors"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
func TestFlagErrorWithSuggestions_authStructured(t *testing.T) {
|
|
t.Parallel()
|
|
cmd := &cobra.Command{Use: "login", Run: func(*cobra.Command, []string) {}}
|
|
orig := fmt.Errorf("unknown flag: --json")
|
|
err := flagErrorWithSuggestions(cmd, orig)
|
|
var ae *apperrors.Error
|
|
if !stderrors.As(err, &ae) {
|
|
t.Fatalf("want *apperrors.Error, got %T", err)
|
|
}
|
|
if ae.Message != orig.Error() {
|
|
t.Fatalf("Message = %q, want %q", ae.Message, orig.Error())
|
|
}
|
|
if ae.Reason != "unknown_flag" {
|
|
t.Fatalf("Reason = %q, want unknown_flag", ae.Reason)
|
|
}
|
|
if ae.Hint == "" || !strings.Contains(ae.Hint, "format json") {
|
|
t.Fatalf("Hint = %q", ae.Hint)
|
|
}
|
|
if ae.Cause != orig {
|
|
t.Fatalf("Cause = %v, want orig", ae.Cause)
|
|
}
|
|
if !stderrors.Is(err, orig) {
|
|
t.Fatal("errors.Is(err, orig) should hold via unwrap")
|
|
}
|
|
}
|
|
|
|
func TestFlagErrorWithSuggestions_unknownFlagHintAndFlags(t *testing.T) {
|
|
t.Parallel()
|
|
cmd := &cobra.Command{Use: "list", Run: func(*cobra.Command, []string) {}}
|
|
cmd.Flags().String("start", "", "begin time")
|
|
_ = cmd.Flags().SetAnnotation("start", "x-cli-format", []string{"date-time"})
|
|
orig := fmt.Errorf("unknown flag: --starttime1")
|
|
err := flagErrorWithSuggestions(cmd, orig)
|
|
var ae *apperrors.Error
|
|
if !stderrors.As(err, &ae) {
|
|
t.Fatalf("want *apperrors.Error, got %T", err)
|
|
}
|
|
if ae.Reason != "unknown_flag" {
|
|
t.Fatalf("Reason = %q", ae.Reason)
|
|
}
|
|
if strings.Contains(ae.Hint, "Space required") {
|
|
t.Fatalf("false glue must not suggest space: %q", ae.Hint)
|
|
}
|
|
if !strings.Contains(ae.Hint, "help") {
|
|
t.Fatalf("expected help fallback in hint, got %q", ae.Hint)
|
|
}
|
|
if len(ae.AvailableFlags) != 1 || ae.AvailableFlags[0] != "start" {
|
|
t.Fatalf("AvailableFlags = %v, want [start]", ae.AvailableFlags)
|
|
}
|
|
}
|