dingtalk-workspace-cli/internal/cli/schema_shards_coverage_test.go

// Copyright 2026 Alibaba Group
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package cli

import (
	"bytes"
	"encoding/json"
	"errors"
	"strings"
	"testing"
	"testing/fstest"

	"github.com/spf13/cobra"
)

// failingReadFS lists entries but fails ReadFile, driving shard-read errors.
type failingReadFS struct{ fstest.MapFS }

func (f failingReadFS) ReadFile(name string) ([]byte, error) {
	if strings.HasSuffix(name, ".json") {
		return nil, errors.New("shard read denied")
	}
	return f.MapFS.ReadFile(name)
}

func TestAssembleSchemaCatalogSnapshotMergesShards(t *testing.T) {
	envelope := []byte(`{"version":1,"surface_hash":"sha256:s","source_hash":"sha256:c","catalog":{"kind":"schema"}}`)
	shards := fstest.MapFS{
		"tools/doc.json":   {Data: []byte(`{"product":"doc","tools":{"doc.copy":{"title":"复制"}}}`)},
		"tools/sheet.json": {Data: []byte(`{"product":"sheet","tools":{"sheet.get":{"title":"读取"}}}`)},
		"tools/README.md":  {Data: []byte("not a shard")},
	}
	snapshot, err := assembleSchemaCatalogSnapshot(envelope, shards, "tools")
	if err != nil {
		t.Fatalf("assembleSchemaCatalogSnapshot() error = %v", err)
	}
	if snapshot.Version != 1 || snapshot.SurfaceHash != "sha256:s" || snapshot.SourceHash != "sha256:c" {
		t.Fatalf("envelope fields lost: %+v", snapshot)
	}
	if len(snapshot.Tools) != 2 || snapshot.Tools["doc.copy"] == nil || snapshot.Tools["sheet.get"] == nil {
		t.Fatalf("tools = %#v, want merged doc.copy + sheet.get", snapshot.Tools)
	}
}

func TestAssembleSchemaCatalogSnapshotFailureModes(t *testing.T) {
	valid := []byte(`{"version":1,"source_hash":"sha256:c","catalog":{}}`)
	if _, err := assembleSchemaCatalogSnapshot([]byte("{bad"), fstest.MapFS{}, "tools"); err == nil || !strings.Contains(err.Error(), "decode embedded schema catalog.json") {
		t.Fatalf("bad envelope err = %v", err)
	}
	if _, err := assembleSchemaCatalogSnapshot(valid, fstest.MapFS{}, "missing-dir"); err == nil || !strings.Contains(err.Error(), "tools directory") {
		t.Fatalf("missing dir err = %v", err)
	}
	badShard := fstest.MapFS{"tools/doc.json": {Data: []byte("{bad")}}
	if _, err := assembleSchemaCatalogSnapshot(valid, badShard, "tools"); err == nil || !strings.Contains(err.Error(), "decode embedded schema catalog shard") {
		t.Fatalf("bad shard err = %v", err)
	}
	denied := failingReadFS{fstest.MapFS{"tools/doc.json": {Data: []byte(`{}`)}}}
	if _, err := assembleSchemaCatalogSnapshot(valid, denied, "tools"); err == nil || !strings.Contains(err.Error(), "read embedded schema catalog shard") {
		t.Fatalf("denied shard err = %v", err)
	}
}

func TestAssembleCommandRegistryFromShards(t *testing.T) {
	envelope := []byte(`{"$schema":"./schema_command_registry.schema.json","version":1}`)
	shards := fstest.MapFS{
		"products/doc.json": {Data: []byte(`{"id":"doc","tools":[{"canonical_path":"doc.copy_document","cli_path":"doc copy"}]}`)},
		"products/notes.md": {Data: []byte("skip me")},
	}
	registry, err := assembleCommandRegistryFrom(envelope, shards, "products")
	if err != nil {
		t.Fatalf("assembleCommandRegistryFrom() error = %v", err)
	}
	if len(registry.Commands) != 1 || registry.Commands[0].CanonicalPath != "doc.copy_document" {
		t.Fatalf("registry = %+v, want single doc.copy_document command", registry.Commands)
	}
}

func TestAssembleCommandRegistryFromFailureModes(t *testing.T) {
	valid := []byte(`{"version":1}`)
	if _, err := assembleCommandRegistryFrom([]byte("{bad"), fstest.MapFS{}, "products"); err == nil || !strings.Contains(err.Error(), "envelope") {
		t.Fatalf("bad envelope err = %v", err)
	}
	if _, err := assembleCommandRegistryFrom(valid, fstest.MapFS{}, "missing-dir"); err == nil || !strings.Contains(err.Error(), "read embedded command registry products") {
		t.Fatalf("missing dir err = %v", err)
	}
	badShard := fstest.MapFS{"products/doc.json": {Data: []byte("{bad")}}
	if _, err := assembleCommandRegistryFrom(valid, badShard, "products"); err == nil || !strings.Contains(err.Error(), "decode embedded command registry shard") {
		t.Fatalf("bad shard err = %v", err)
	}
	denied := failingReadFS{fstest.MapFS{"products/doc.json": {Data: []byte(`{}`)}}}
	if _, err := assembleCommandRegistryFrom(valid, denied, "products"); err == nil || !strings.Contains(err.Error(), "read embedded command registry shard") {
		t.Fatalf("denied shard err = %v", err)
	}
}

func TestMergedCommandRegistryJSONFailureModes(t *testing.T) {
	valid := []byte(`{"version":1}`)
	if _, err := mergedCommandRegistryJSON([]byte("{bad"), fstest.MapFS{}, "products"); err == nil {
		t.Fatal("bad envelope should fail")
	}
	if _, err := mergedCommandRegistryJSON(valid, fstest.MapFS{}, "missing-dir"); err == nil {
		t.Fatal("missing dir should fail")
	}
	denied := failingReadFS{fstest.MapFS{"products/doc.json": {Data: []byte(`{}`)}}}
	if _, err := mergedCommandRegistryJSON(valid, denied, "products"); err == nil {
		t.Fatal("denied shard should fail")
	}
	// Invalid shard JSON survives assembly as RawMessage but fails the final
	// products marshal.
	badShard := fstest.MapFS{"products/doc.json": {Data: []byte("{bad")}}
	if _, err := mergedCommandRegistryJSON(valid, badShard, "products"); err == nil {
		t.Fatal("invalid RawMessage shard should fail marshal")
	}
}

func TestMergedCommandRegistryJSONDefaultsSchemaAndSkipsNonJSON(t *testing.T) {
	shards := fstest.MapFS{
		"products/doc.json": {Data: []byte(`{"id":"doc","tools":[]}`)},
		"products/notes.md": {Data: []byte("skip me")},
	}
	data, err := mergedCommandRegistryJSON([]byte(`{"version":1}`), shards, "products")
	if err != nil {
		t.Fatalf("mergedCommandRegistryJSON() error = %v", err)
	}
	var merged struct {
		Schema   string            `json:"$schema"`
		Version  int               `json:"version"`
		Products []json.RawMessage `json:"products"`
	}
	if err := json.Unmarshal(data, &merged); err != nil {
		t.Fatal(err)
	}
	if merged.Schema != "./schema_command_registry.schema.json" {
		t.Fatalf("schema = %q, want defaulted schema path", merged.Schema)
	}
	if len(merged.Products) != 1 {
		t.Fatalf("products = %d, want 1 (markdown skipped)", len(merged.Products))
	}
}

func TestBuildMetaByCLIPathGuards(t *testing.T) {
	// nil Tools：损坏快照直接返回空表。
	if got := buildMetaByCLIPath(loadedSchemaCatalog{}); len(got) != 0 {
		t.Fatalf("nil tools lookup = %#v, want empty", got)
	}
	loaded := loadedSchemaCatalog{Snapshot: SchemaCatalogSnapshot{Tools: map[string]map[string]any{
		"doc.no_cli_path": {"canonical_path": "doc.no_cli_path"},
		"doc.primary": {
			"cli_path":       "doc primary",
			"canonical_path": "doc.primary",
			"aliases":        []any{"doc alias", "doc primary", "  ", float64(1)},
		},
		"doc.other": {
			"cli_path":       "doc alias",
			"canonical_path": "doc.other",
		},
	}}}
	lookup := buildMetaByCLIPath(loaded)
	if _, ok := lookup[""]; ok {
		t.Fatal("entry without cli_path must be skipped")
	}
	// 别名与其他命令的主路径冲突时，主路径必须胜出。
	if got := lookup["doc alias"].Identity.Canonical; got != "doc.other" {
		t.Fatalf("doc alias resolved to %q, want primary owner doc.other", got)
	}
	if got := lookup["doc primary"].Identity.Canonical; got != "doc.primary" {
		t.Fatalf("doc primary resolved to %q", got)
	}
	// Identity.Aliases 保留 Catalog 中的字符串成员（非字符串被丢弃）；
	// 空白/自指别名仅在查找表注册时跳过。
	if aliases := lookup["doc primary"].Identity.Aliases; len(aliases) != 3 {
		t.Fatalf("aliases = %v, want the 3 string members (float dropped)", aliases)
	}
}

func TestCatalogStringSliceValNonSlice(t *testing.T) {
	if got := catalogStringSliceVal(map[string]any{"aliases": "not-a-slice"}, "aliases"); got != nil {
		t.Fatalf("catalogStringSliceVal() = %v, want nil", got)
	}
}

func TestRenderSafetyAnnotation(t *testing.T) {
	// dev app delete: destructive/high/user_required —— 必须渲染完整注解。
	root := &cobra.Command{Use: "dws"}
	dev := &cobra.Command{Use: "dev"}
	app := &cobra.Command{Use: "app"}
	deleteCmd := &cobra.Command{Use: "delete"}
	root.AddCommand(dev)
	dev.AddCommand(app)
	app.AddCommand(deleteCmd)
	var out bytes.Buffer
	deleteCmd.SetOut(&out)
	RenderSafetyAnnotation(deleteCmd)
	rendered := out.String()
	if !strings.Contains(rendered, "Safety: effect=destructive") || !strings.Contains(rendered, "(需 --yes)") {
		t.Fatalf("rendered = %q, want destructive annotation with confirmation hint", rendered)
	}
	if !strings.Contains(rendered, "idempotency=") {
		t.Fatalf("rendered = %q, want idempotency field", rendered)
	}

	// 未收录命令不输出任何内容。
	unknown := &cobra.Command{Use: "unknown-cmd"}
	root.AddCommand(unknown)
	var silent bytes.Buffer
	unknown.SetOut(&silent)
	RenderSafetyAnnotation(unknown)
	if silent.Len() != 0 {
		t.Fatalf("unknown command rendered %q, want empty", silent.String())
	}
}

// TestAssembleEmbeddedSchemaCatalogPropagatesAssemblyError 通过临时替换嵌入的
// envelope 字节，覆盖 assembleEmbeddedSchemaCatalog 的错误透传分支。
func TestAssembleEmbeddedSchemaCatalogPropagatesAssemblyError(t *testing.T) {
	orig := embeddedSchemaCatalogEnvelopeJSON
	t.Cleanup(func() { embeddedSchemaCatalogEnvelopeJSON = orig })
	embeddedSchemaCatalogEnvelopeJSON = []byte("{bad")
	if _, err := assembleEmbeddedSchemaCatalog(); err == nil || !strings.Contains(err.Error(), "decode embedded schema catalog.json") {
		t.Fatalf("err = %v, want assembly error passthrough", err)
	}
}