DennisandClaude Opus 4.8
d2e36a76e2
- minutes: drop the minutesId/minutes_id candidate from the taskUuid mapping. minutesId is the minutes document id, a different identifier from the recording taskUuid that +record-pause/resume/stop consume via --id, so substituting it would feed record control a wrong id. The backend list already returns taskUuid; the guard test now asserts taskUuid/task_uuid. - Rewrite the guard-test failure messages and fixture data in English to match the repository convention (only the two assertions that match the production Chinese validation string are kept). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
71 lines
2.6 KiB
Go
71 lines
2.6 KiB
Go
// Copyright 2026 Alibaba Group
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package attendance
|
|
|
|
import (
|
|
"encoding/json"
|
|
"testing"
|
|
)
|
|
|
|
// TestSearchClassProjectShiftVOShape guards against projection-data-loss:
|
|
// get_class_list nests the list under result.items and wraps each shift's
|
|
// identity under shiftVO. The projection must unwrap shiftVO or +search-class
|
|
// silently returns empty despite the backend returning shifts.
|
|
func TestSearchClassProjectShiftVOShape(t *testing.T) {
|
|
const raw = `{"result":{"items":[
|
|
{"shiftVO":{"id":957395083,"name":"default shift"}},
|
|
{"shiftVO":{"id":957395084,"name":"morning shift"}}
|
|
]}}`
|
|
var data map[string]any
|
|
if err := json.Unmarshal([]byte(raw), &data); err != nil {
|
|
t.Fatalf("unmarshal fixture: %v", err)
|
|
}
|
|
got := searchClassProject(data)
|
|
if len(got) != 2 {
|
|
t.Fatalf("lower/upper mismatch: 2 shifts in backend, projection returned %d (%v)", len(got), got)
|
|
}
|
|
if got[0]["name"] == nil || got[0]["classId"] == nil {
|
|
t.Fatalf("shiftVO fields not unwrapped: %v", got[0])
|
|
}
|
|
}
|
|
|
|
// TestSearchRuleProjectEntityVOShape guards get_overtime_rule (result.atRuleList)
|
|
// and get_adjustment_rule (result.adjustmentList), both wrapping the rule under
|
|
// entityVO. The resolver must probe those keys and unwrap entityVO or
|
|
// +search-overtime-rule / +search-adjustment-rule silently return empty.
|
|
func TestSearchRuleProjectEntityVOShape(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
name, key string
|
|
}{
|
|
{"overtime", "atRuleList"},
|
|
{"adjustment", "adjustmentList"},
|
|
} {
|
|
raw := `{"result":{"` + tc.key + `":[
|
|
{"entityVO":{"id":11,"name":"weekday overtime"},"permissionVO":{}},
|
|
{"entityVO":{"id":12,"name":"holiday overtime"},"permissionVO":{}}
|
|
]}}`
|
|
var data map[string]any
|
|
if err := json.Unmarshal([]byte(raw), &data); err != nil {
|
|
t.Fatalf("[%s] unmarshal fixture: %v", tc.name, err)
|
|
}
|
|
got := searchRuleProject(data)
|
|
if len(got) != 2 {
|
|
t.Fatalf("[%s] lower/upper mismatch: result.%s has 2 entries, projection returned %d", tc.name, tc.key, len(got))
|
|
}
|
|
if got[0]["ruleId"] == nil || got[0]["name"] == nil {
|
|
t.Fatalf("[%s] entityVO fields not unwrapped: %v", tc.name, got[0])
|
|
}
|
|
}
|
|
}
|