修雨
c151756168
Five operational gaps that bite when a connector-backed bot answers questions in real groups: - Single-instance lock: one connector per robot per machine (pid file, stale-lock takeover). Duplicate Stream connections on one clientId get messages load-balanced between them, so the bot answers intermittently (verified live). - Access policy: --allowed-users / --allowed-groups allowlists plus a per-sender rate limit (--user-rate-limit, default 20/min). Every message is an LLM call; without this anyone who can reach the bot can spend on its behalf. - Per-conversation FIFO queue: same-chat messages run in arrival order (follow-ups need the previous turn's --resume session; parallel CLIs racing one session corrupt it); different chats stay parallel. - Picture messages: resolve the callback downloadCode via robot messageFiles/download to a local temp file and hand the path to the agent CLI — error screenshots are the top Q&A inbound and were previously dropped silently. The claudecode persona now permits reading attached files. - --knowledge-dir: lightweight local retrieval (markdown chunking, latin-token + CJK-bigram scoring) prepends top-k matching chunks to each question while the agent keeps running from the clean scratch dir, so replies stay inside DingTalk's AI-assistant response window. All knobs have env mirrors (DWS_ALLOWED_USERS / DWS_ALLOWED_GROUPS / DWS_USER_RATE_LIMIT / DWS_KNOWLEDGE_DIR) for service-style runs. go build ./... clean; go test ./internal/helpers -race passes with new tests for lock/gate/queue/knowledge/media. test/cli_compat, test/scripts and test/unit fail identically on the unmodified base (pre-existing fixture issues).
57 lines
1.7 KiB
Go
57 lines
1.7 KiB
Go
// Copyright 2026 Alibaba Group
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package helpers
|
|
|
|
import "sync"
|
|
|
|
// convQueue serialises message handling per conversation: same-chat messages
|
|
// run in arrival order — a Q&A follow-up ("还是不行") must see the previous
|
|
// turn's session state, and two parallel agent CLIs racing on one --resume
|
|
// session corrupt the transcript. Different conversations stay parallel.
|
|
// Ported from the hermes gateway's per-session promise chain
|
|
// (gateway/run.py session queues).
|
|
type convQueue struct {
|
|
mu sync.Mutex
|
|
tails map[string]chan struct{}
|
|
}
|
|
|
|
func newConvQueue() *convQueue {
|
|
return &convQueue{tails: map[string]chan struct{}{}}
|
|
}
|
|
|
|
// run schedules fn after the conversation's previous task and returns
|
|
// immediately (the Stream callback must ack fast). The chain entry is removed
|
|
// once the queue for that conversation drains, so idle chats hold no memory.
|
|
func (q *convQueue) run(convID string, fn func()) {
|
|
q.mu.Lock()
|
|
prev := q.tails[convID]
|
|
done := make(chan struct{})
|
|
q.tails[convID] = done
|
|
q.mu.Unlock()
|
|
go func() {
|
|
defer func() {
|
|
close(done)
|
|
q.mu.Lock()
|
|
if q.tails[convID] == done {
|
|
delete(q.tails, convID)
|
|
}
|
|
q.mu.Unlock()
|
|
}()
|
|
if prev != nil {
|
|
<-prev
|
|
}
|
|
fn()
|
|
}()
|
|
}
|