ybc❤️zyrand猷诺 efb61cae02 fix: restore unconditional MCP re-fetch in login to prevent stale clientId errors (#213) ...

PR #184 merge conflict resolution inadvertently introduced a conditional
branch that preserved stale clientID from previous login sessions instead
of always re-fetching from MCP server. This caused exchangeCode() to use
direct DingTalk API mode (which requires clientSecret) instead of MCP
proxy mode, resulting in 'clientId或者clientSecret错误' errors.

This commit restores the original PR #157 logic: both DeviceFlowProvider
and OAuthProvider unconditionally call resetCredentialState() followed by
FetchClientIDFromMCP() + SetClientIDFromMCP(), ensuring exchangeCode()
always uses the MCP proxy path regardless of prior login state.

Root cause: the conditional branch treated any non-empty clientID (from
runtimeClientID or app.json) as a user-provided --client-id flag value,
skipping MCP re-fetch and leaving clientIDFromMCP=false after reset.

Affected scenarios:
- OAuth login → device flow login
- Any login → --force login
- New terminal with existing app.json → device flow login

Fixes regression introduced in PR #184 (commit 46192d6).
Restores fix from PR #157 (commit ad33a46).

Co-authored-by: 猷诺 <bicheng.ybc@alibaba-inc.com>

2026-05-04 09:26:25 +08:00

..

app_config.go

feat(auth): persist client credentials and optimize keychain access

2026-03-30 11:57:07 +08:00

app_token_test.go

feat: The token retrieval interface is now unified to one.

2026-04-27 15:11:12 +08:00

app_token.go

feat(api): add raw DingTalk OpenAPI command with dual-version token support

2026-04-27 20:54:57 +08:00

auth_extra_test.go

feat(auth): enhance device flow with CLI auth check and admin guidance

2026-04-01 00:47:49 +08:00

browser_unix.go

init

2026-03-27 17:55:57 +08:00

browser_windows.go

init

2026-03-27 17:55:57 +08:00

browser.go

init

2026-03-27 17:55:57 +08:00

channel.go

feat(pat)!: A-core loop for host-owned PAT (#142)

2026-04-28 21:17:23 +08:00

classify_denial_reason_test.go

fix(auth): attribute CLI auth denial to channel before user scope (#144)

2026-04-22 12:05:30 +08:00

cli_auth_check_test.go

feat: PAT scope error visualization and auto-retry with authorization polling (#113)

2026-04-19 19:12:34 +08:00

credential_reset_test.go

fix: device flow defensively resets credentials before login (#155) (#157)

2026-04-24 14:11:16 +08:00

device_flow_status.go

feat: PAT scope error visualization and auto-retry with authorization polling (#113)

2026-04-19 19:12:34 +08:00

device_flow_test.go

fix: preserve PAT authorization uri and accept result poll envelope (#182)

2026-04-27 20:04:01 +08:00

device_flow.go

fix: restore unconditional MCP re-fetch in login to prevent stale clientId errors (#213)

2026-05-04 09:26:25 +08:00

endpoints.go

feat(api): add raw DingTalk OpenAPI command with dual-version token support

2026-04-27 20:54:57 +08:00

filelock_test.go

逻辑优化

2026-03-28 17:51:22 +08:00

filelock_unix.go

init

2026-03-27 17:55:57 +08:00

filelock_windows.go

init

2026-03-27 17:55:57 +08:00

filelock.go

feat: edition layer for Wukong overlay; promote shared code to pkg/

2026-03-31 15:29:21 +08:00

force_refresh.go

feat(discovery): MCP discovery service abstraction with positional params, examples, defaults, and schema v3 extensions (#156)

2026-04-24 14:08:17 +08:00

identity.go

feat: edition layer for Wukong overlay; promote shared code to pkg/

2026-03-31 15:29:21 +08:00

keychain_store.go

feat(auth): persist OAuth credentials for reliable token refresh

2026-04-01 11:03:08 +08:00

manager_test.go

init

2026-03-27 17:55:57 +08:00

manager.go

chore: group pkg imports per goimports

2026-03-31 15:32:50 +08:00

oauth_helpers.go

fix(auth): attribute CLI auth denial to channel before user scope (#144)

2026-04-22 12:05:30 +08:00

oauth_provider.go

fix: restore unconditional MCP re-fetch in login to prevent stale clientId errors (#213)

2026-05-04 09:26:25 +08:00

secret.go

feat(auth): persist client credentials for token refresh

2026-03-30 10:53:26 +08:00

secure_store_test.go

init

2026-03-27 17:55:57 +08:00

secure_store.go

chore: group pkg imports per goimports

2026-03-31 15:32:50 +08:00

testmain_test.go

feat(discovery): MCP discovery service abstraction with positional params, examples, defaults, and schema v3 extensions (#156)

2026-04-24 14:08:17 +08:00

token_test.go

feat(discovery): MCP discovery service abstraction with positional params, examples, defaults, and schema v3 extensions (#156)

2026-04-24 14:08:17 +08:00

token.go

feat(auth): delegate token persistence to edition hooks with keychain fallback

2026-04-10 23:33:11 +08:00