github/dingtalk-workspace-cli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(todo): preserve priority schema compatibility

Browse Source
This commit is contained in:
克谨
2026-08-24 23:33:43 +08:00
parent 46fdaed90b
commit a4813f78bc
2 changed files with 31 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/helpers/todo.go
+6 -9
View File
@@ -160,7 +160,7 @@ func newTodoCommand() *cobra.Command {
Parameters: []contract.ParamDecl{
{Name: "due", Property: "PersonalTodoCreateVO.dueTime"},
{Name: "executors", Property: "PersonalTodoCreateVO.executorIds", Description: "执行者 userId 列表；逗号分隔，解析后至少包含一个非空值"},
{Name: "priority", Property: "PersonalTodoCreateVO.priority", Enum: []string{"10", "20", "30", "40"}},
{Name: "priority", Property: "PersonalTodoCreateVO.priority"},
{Name: "recurrence", Property: "PersonalTodoCreateVO.recurrence"},
{Name: "title", Property: "PersonalTodoCreateVO.subject"},
},
@@ -261,7 +261,7 @@ func newTodoCommand() *cobra.Command {
{Name: "due", Property: "PersonalTodoCreateVO.dueTime"},
{Name: "executors", Property: "PersonalTodoCreateVO.executorIds", Description: "执行者 userId 列表；逗号分隔，解析后至少包含一个非空值"},
{Name: "parent-id", Property: "PersonalTodoCreateVO.parentId"},
{Name: "priority", Property: "PersonalTodoCreateVO.priority", Enum: []string{"10", "20", "30", "40"}},
{Name: "priority", Property: "PersonalTodoCreateVO.priority"},
{Name: "recurrence", Property: "PersonalTodoCreateVO.recurrence"},
{Name: "title", Property: "PersonalTodoCreateVO.subject"},
},
@@ -434,7 +434,7 @@ func newTodoCommand() *cobra.Command {
Parameters: []contract.ParamDecl{
{Name: "done", Property: "TodoUpdateRequest.isDone"},
{Name: "due", Property: "TodoUpdateRequest.dueTime"},
{Name: "priority", Property: "TodoUpdateRequest.priority", Enum: []string{"10", "20", "30", "40"}},
{Name: "priority", Property: "TodoUpdateRequest.priority"},
{Name: "task-id", Property: "TodoUpdateRequest.taskId"},
{Name: "title", Property: "TodoUpdateRequest.subject"},
},
@@ -1928,15 +1928,12 @@ func parseRequiredTodoIDs(flagName, value string) ([]string, error) {
func parseTodoPriority(value string) (int, error) {
priority, err := strconv.Atoi(strings.TrimSpace(value))
if err == nil {
switch priority {
case 10, 20, 30, 40:
return priority, nil
}
return priority, nil
}
return 0, apperrors.NewValidation(
"--priority 仅接受 10/20/30/40",
"--priority 必须是整数",
apperrors.WithReason("invalid_priority"),
apperrors.WithHint("优先级映射：10=低、20=普通、30=较高、40=紧急"),
apperrors.WithHint("常用优先级映射：10=低、20=普通、30=较高、40=紧急"),
apperrors.WithExecutionStarted(false),
apperrors.WithRetryable(false),
)
internal/helpers/todo_command_edges_more_test.go
+25 -15
View File
@@ -6,6 +6,7 @@ import (
"io"
"os"
"path/filepath"
"strconv"
"strings"
"testing"
@@ -47,7 +48,6 @@ func TestCrossPlatformCoverageTodoCreateAndListCommandEdges(t *testing.T) {
{"task", "create", "--title", "x", "--executors", "u", "--remind-at", validDate},
{"task", "create", "--title", "x", "--executors", "u", "--due", "bad"},
{"task", "create", "--title", "x", "--executors", "u", "--priority", "bad"},
{"task", "create", "--title", "x", "--executors", "u", "--priority", "25"},
{"task", "create-sub", "--title", "x", "--executors", "u", "--parent-id", "abc"},
{"task", "create-sub", "--title", "x", "--executors", "u", "--parent-id", "1", "--remind-at", validDate},
{"task", "create-sub", "--title", "x", "--executors", "u", "--parent-id", "1", "--due", "bad"},
@@ -79,7 +79,7 @@ func TestCrossPlatformCoverageTodoCreateAndListCommandEdges(t *testing.T) {
}
}
func TestCrossPlatformCoverageTodoRejectsEmptyExecutorCSVAndInvalidPriorityBeforeCall(t *testing.T) {
func TestCrossPlatformCoverageTodoRejectsEmptyExecutorCSVAndNonNumericPriorityBeforeCall(t *testing.T) {
tests := []struct {
name string
reason string
@@ -90,9 +90,6 @@ func TestCrossPlatformCoverageTodoRejectsEmptyExecutorCSVAndInvalidPriorityBefor
{name: "add empty executors", reason: "invalid_executors", args: []string{"task", "add-executor", "--task-id", "1", "--executors", ",,,"}},
{name: "remove empty executors", reason: "invalid_executors", args: []string{"task", "remove-executor", "--task-id", "1", "--executors", ",,,"}},
{name: "create nonnumeric priority", reason: "invalid_priority", args: []string{"task", "create", "--title", "x", "--executors", "u", "--priority", "normal"}},
{name: "create unsupported priority", reason: "invalid_priority", args: []string{"task", "create", "--title", "x", "--executors", "u", "--priority", "25"}},
{name: "create-sub unsupported priority", reason: "invalid_priority", args: []string{"task", "create-sub", "--parent-id", "1", "--title", "x", "--executors", "u", "--priority", "25"}},
{name: "update unsupported priority", reason: "invalid_priority", args: []string{"task", "update", "--task-id", "1", "--priority", "25"}},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
@@ -112,18 +109,31 @@ func TestCrossPlatformCoverageTodoRejectsEmptyExecutorCSVAndInvalidPriorityBefor
}
}
func TestCrossPlatformCoverageTodoCreateAcceptsNormalPriority(t *testing.T) {
caller := &scriptedToolCaller{}
if err := executeTodoEdge(t, caller, "task", "create", "--title", "x", "--executors", "u", "--priority", "20"); err != nil {
t.Fatalf("create priority 20: %v", err)
func TestCrossPlatformCoverageTodoCreateAcceptsNumericPriority(t *testing.T) {
for _, priority := range []string{"20", "25"} {
t.Run(priority, func(t *testing.T) {
caller := &scriptedToolCaller{}
if err := executeTodoEdge(t, caller, "task", "create", "--title", "x", "--executors", "u", "--priority", priority); err != nil {
t.Fatalf("create priority %s: %v", priority, err)
}
if caller.calls != 1 || caller.tool != "create_personal_todo" {
t.Fatalf("calls = %d tool = %q", caller.calls, caller.tool)
}
request, ok := caller.args["PersonalTodoCreateVO"].(map[string]any)
if !ok || request["priority"] != mustTodoAtoi(t, priority) {
t.Fatalf("request = %#v, want priority %s", caller.args, priority)
}
})
}
if caller.calls != 1 || caller.tool != "create_personal_todo" {
t.Fatalf("calls = %d tool = %q", caller.calls, caller.tool)
}
request, ok := caller.args["PersonalTodoCreateVO"].(map[string]any)
if !ok || request["priority"] != 20 {
t.Fatalf("request = %#v, want priority 20", caller.args)
}
func mustTodoAtoi(t *testing.T, value string) int {
t.Helper()
parsed, err := strconv.Atoi(value)
if err != nil {
t.Fatalf("parse %q: %v", value, err)
}
return parsed
}
func TestCrossPlatformCoverageTodoSimpleCommandValidationAndSuccessEdges(t *testing.T) {